First round of LoadConstant auditing
#5140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Merged
`Constant` IR op needs the frontend to be audited and pass padding information through.
`ThreadRemoveCodeEntry` doesn't properly have relations wired up but it does use the Entry. So this would be broken on code caching with relocations.
All direct usages have been audited. Now we need to do indirect usages through the `Constant` IR operation.
Collaborator
|
I feel that NOPAD should really be a default arg here, the cases where padding is required are purely relocations which are special anyway and one would be aware if padding were necessary when writing such code. It adds a lot of noise otherwise |
Member
Author
I'll do that as a post-merge change. I want to ensure that if code-caching needs to get bisected through this that it doesn't break. |
bylaws
approved these changes
Dec 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audits the direct uses of
LoadConstantfor padding requirements.Two things:
ThreadRemoveCodeEntryuses the block entry but relocations aren't wired up to it. This will break under codecachingConstantIR op needs to be audited through the OpcodeDispatcher, with padding data passed through from the dispatcher.This should reduce a significant amount of padding from happening in the JIT with code caching enabled, even with this first pass. I'll be walking through the OpcodeDispatcher for their use of padding required constants and working on passing that information through to the backend.